Skip to content

Fix index increment in Signature validation #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aeberhart merged 2 commits into from
Oct 24, 2025
Merged

Fix index increment in Signature validation #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62b3d54
Fix index increment in Signature validation
Advaitva Oct 21, 2025
d7fa65a
Unit test proving signature calculation issue
Advaitva Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/main/java/com/dashjoin/jsonata/utils/Signature.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,6 +391,7 @@ public Object validate(Object _args, Object context) {
}
}
}
index++;
}
return validatedArgs;
}
Expand Down
13 changes: 13 additions & 0 deletions src/test/java/com/dashjoin/jsonata/SignatureTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,4 +55,17 @@ public Object call(Object input, List args) throws Throwable {
}, "<n+:n>"));
Assertions.assertEquals(6, expression.evaluate(null));
}

@Test
public void testVarArgMany(){
Jsonata expr = jsonata("$customArgs('test',[1,2,3,4],3)");
expr.registerFunction("customArgs", new JFunction(new JFunctionCallable() {

@Override
public Object call(Object input, @SuppressWarnings("rawtypes") List args) throws Throwable {
return args.toString();
}
}, "<sa<n>n:s>"));
Assertions.assertEquals("[test, [1, 2, 3, 4], 3]", expr.evaluate(null));
}
}
Loading