fix(vectored): resolve type aliasing bug causing missed matches (#202) #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
darvid
commented
Nov 29, 2025
darvid
commented
- Change lengths array from Py_ssize_t to uint32_t to match hs_scan_vector API
- On 64-bit systems, casting Py_ssize_t* to uint32_t* caused Hyperscan to read incorrect buffer lengths (every other buffer got length 0)
- Update test expectations to reflect correct match offsets
- Change lengths array from Py_ssize_t to uint32_t to match hs_scan_vector API - On 64-bit systems, casting Py_ssize_t* to uint32_t* caused Hyperscan to read incorrect buffer lengths (every other buffer got length 0) - Update test expectations to reflect correct match offsets
- Use branch ref name instead of SHA for git fetch (SHA fetch doesn't work) - Consolidate PR handling into single block to avoid duplicate fetches - Add stderr suppression for cleaner error handling
darvid
force-pushed
the
fix/issue-202-vectored-scan-type-aliasing
branch
from
ba0bd01 to
e70ebb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.