Migrating task model and backend to use typed_sql.#9410
Open
isoos wants to merge 7 commits into
Open
Conversation
Collaborator
isoos
commented
May 25, 2026
- This reverts commit 3796fab.
Collaborator
Author
|
Note: this is re-applying the original rewrite + layering several commits on top of it that address the re-entrant transactions, the query + transaction on the same connection pattern and simplify further parts, e.g. how the dependency timestamp gets updated and read periodically. |
sigurdm
approved these changes
May 28, 2026
sigurdm
reviewed
May 28, 2026
| scheduleMicrotask(() async { | ||
| await pool.withResource(() async { | ||
| for (final p in packageNames) { | ||
| unawaited( |
Contributor
There was a problem hiding this comment.
I guess you disconnect the stacktraces here. Not sure if it is important.
Collaborator
Author
There was a problem hiding this comment.
The previous version did disconnect them. The new code preserves the full stacktrace, puts them into a concurrent pool, and then awaits them. I just don't await the individual future that the pool returns. Previously we have used:
final f = pool.schedue...
futures.add(f);
await Futures.wait(futures);
But I think it is no longer necessary with this block + awaiting the pool.close();
sigurdm
approved these changes
May 28, 2026
…g#9126)" (dart-lang#9393) This reverts commit 3796fab.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.