Track and join pending database transaction when using transactWithRetry#9398
Open
isoos wants to merge 1 commit into
Open
Track and join pending database transaction when using transactWithRetry#9398isoos wants to merge 1 commit into
isoos wants to merge 1 commit into
Conversation
Member
I think it's only concurrent nested subtransactions that disallowed. |
Member
|
See also google/dart-neats#372 That said, one can argue that we probably don't need nested transactions, and instead just want single transactions. Where in our code is this even relevant? |
Collaborator
Author
|
Note: this may not be needed after all. Though, we could use this to detect re-entrant transaction calls, which we probably don't want, and maybe block them? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note:
typed_sql(or specifically the postgresql driver) doesn't support re-entrant calling ofdb.transact(). With this change we don't force-start a new transaction, just use the outer one (same logic as with joining the outermost retry block).