[AI] Fix corrupted AI output when provider is set to auto#21063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A user on pixls.us reported posterized blue/magenta raw denoise output on macOS – but only with "auto" selected. Explicit "CoreML" or "CPU" worked fine.
The
rawdenoise-nindmanifest declarescpu_only: { model_bayer: [coreml] }, telling the backend that the Bayer head needs CoreML's CPU compute units (the ANE/GPU path produces garbage). That check ran for explicit "CoreML" but was exempted for "auto" – so on macOS "auto" enabled CoreML withoutUSE_CPU_ONLYand ran on the ANE.Rather than special-casing macOS, AUTO and
cpu_onlynow flow through one resolver inbackend_common.c:[CoreML], Windows:[DirectML], Linux:[CUDA, MIGraphX, OpenVINO]) and appliescpu_onlyto each. First candidate that's available and either not banned, or (CoreML) tolerable viaUSE_CPU_ONLY, wins._enable_accelerationno longer carries an AUTO case – the resolver guarantees a concrete EP.dt_ai_probe_provider; probe results are memoized per process.Linux AUTO on a model that bans one GPU EP now falls through to the next instead of dropping straight to CPU. Explicit-EP and CPU paths are unchanged.