colorcalibration also for manual wb#20304
Open
kofa73 wants to merge 22 commits intodarktable-org:masterfrom
Open
colorcalibration also for manual wb#20304kofa73 wants to merge 22 commits intodarktable-org:masterfrom
kofa73 wants to merge 22 commits intodarktable-org:masterfrom
Conversation
Collaborator
|
Did you intend to include cmixer_orig.c.txt in the PR? |
Contributor
Author
See the end of the description:
|
6631dc3 to
be0ad7a
Compare
Contributor
Author
|
@ralfbrown : extra files removed, thank for your patience |
…x for in-camera, picked and manual WB
…te_correction flag for 'legacy' modes (DT_IOP_TEMP_AS_SHOT, DT_IOP_TEMP_SPOT, DT_IOP_TEMP_USER)
…rything is purple.
…calibration-also-for-manual-wb.md
…ERA (then gradually separate them, in small steps)
…re_from_as_shot_coeffs; factored out find_temperature_from_wb_coeffs
…MERA in many cases; what to do with illuminant_to_xy?
…ios (renamed from misleading custom_wb)
be0ad7a to
ce74cf6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #19873
added a new checkbox, prepare data for color calibration to white balance
temperature.cto explicitly control thelate_correctionflag in 'user' / 'manual' modeslate_correctionis always off in 'camera reference' mode, always on in 'as-shot to reference')replaced reference
chr->as_shotwithchr->wb_coeffsinhighlights.c,colorin.c,opposed.candsegbased.cilluminants.h:DT_ILLUMINANT_FROM_WB, plus handling in conditionals, similar toDT_ILLUMINANT_CAMERA, but relying ondev->chroma->wb_coeffsfind_temperature_from_raw_coeffs:find_temperature_from_as_shot_coeffsfind_temperature_from_wb_coeffs, to allow directly using coefficients fromtemperature.c, instead of always going through ratios relative to the D65 valueswb_coeffstoilluminant_to_xyfor absolute coefficients fromtemperature.c; renamed paramcustom_wbtocorrection_ratiosto express what it represents; passed tofind_temperature_from_wb_coeffsinDT_ILLUMINANT_FROM_WBmodechannelmixerrgb.c:_dev_is_D65_chromano longer needsas_shotmultipliers inlate_correctionmode_get_white_balance_coeffto_get_d65_correction_ratiosfind_temperature_from_wb_coeffsto handleDT_ILLUMINANT_FROM_WBDraft for now, to allow discussion (and I haven't tested much, but wanted to make the changes visible to others;
plus, I need to clean up some temp files)