lighttable: preserve custom sort order when switching to custom sort#20166
Open
engrzani wants to merge 3 commits intodarktable-org:masterfrom
Open
lighttable: preserve custom sort order when switching to custom sort#20166engrzani wants to merge 3 commits intodarktable-org:masterfrom
engrzani wants to merge 3 commits intodarktable-org:masterfrom
Conversation
When users switch to custom sort mode, preserve the current sort order instead of resetting to filename order. This allows users to sort by capture time (or any other criterion) first, then switch to custom sort to make fine adjustments without losing their work. Fixes darktable-org#12612
Contributor
|
Did you read any of the comments on #20162? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issue #12612 by preserving the current sort order when switching to "custom sort" mode.
Problem
Previously, when users selected "custom sort" from the sorting dropdown, the image order would reset to filename order. This made it impossible to:
Solution
When switching to custom sort, the current sort order is now captured and stored in the position field, so users can make adjustments to the existing order rather than starting from scratch.
Implementation
dt_collection_sync_custom_order()function to capture current orderTesting
Fixes #12612