AgX refactoring and preset changes#20120
AgX refactoring and preset changes#20120kofa73 wants to merge 4 commits intodarktable-org:masterfrom
Conversation
|
@kofa73 : This is too big for 5.4.1 and also contains strings changes which cannot be integrated into 5.4.1. Would it be possible to extract from this the fixes, if I'm not mistaken those are:
TIA. |
|
OK, I'll extract those into a separate PR tomorrow. Thanks for the feedback.
|
|
#20122 for 5.4.1 |
f4fb67a to
4e0ef5c
Compare
|
Needs conflict resolution. TIA. |
|
Resolved and pushed, but I haven't had time to re-test. I'll try to do that before the end of the week. |
4e0ef5c to
2e754a6
Compare
…reset or a preset is loaded, the 'primaries' controls remain hidden even though the checkbox is unchecked and the primaries take effect.
|
Tested. Also caught and fixed a bug (introduced with the previous set of GUI changes). @dterrahe, I'd be grateful if you could please double-check the last commit: the intention is to restore the visibility of the primaries controls if they are hidden by ticking the 'disable adjustments' checkbox, and then resetting the module / loading a preset. |
Technical changes:
darktable.gui->resetis setgui_updatefromgui_init(agx: Fix crash during initialisation #19745 (comment))gui_changedaftergui_update(agx: Fix crash during initialisation #19745 (comment))_update_redraw_dynamic_gui_update_pivot_slider_settingsDefaults and presets
UI:
Minor:
This PR replaces #19745