Skip to content

AgX refactoring and preset changes#20120

Open
kofa73 wants to merge 4 commits intodarktable-org:masterfrom
kofa73:agx-various-fixes
Open

AgX refactoring and preset changes#20120
kofa73 wants to merge 4 commits intodarktable-org:masterfrom
kofa73:agx-various-fixes

Conversation

@kofa73
Copy link
Contributor

@kofa73 kofa73 commented Jan 10, 2026

Technical changes:

Defaults and presets

  • based on own experience and user feedback (https://discuss.pixls.us/t/more-punchy-contrasted-look-in-agx-by-default/55279/), I've made the defaults more contrasty; the new default contrast and toe/shoulder power are now similar to the 'sigmoid look' that people have grown accustomed to.
  • added 'sigmoid-like' presets that very closely exactly match the tone curve of sigmoid with its default params and the 'smooth' preset. For 'sigmoid-like|smooth', hue preservation is set to 100% (like in sigmoid's own 'smooth' preset), and primaries are set like in sigmoid (using the 'smooth' set). For 'sigmoid-like|default', hue preservation remains at 0% (like in sigmoid), however, unlike sigmoid (which uses unmodified primaries), Blender-like primaries are used (we don't want to disable the core feature).
  • I only kept 'punchy' for Blender, as the other presets are quite contrasty already.

UI:

  • primaries selection remains visible even when "disable adjustments" is checked (disable adjustments is about rotations and in/outset, not about the base primary)
  • use dt_ui_label_new to fix Agx module makes window too big #19970
  • reworded the toe/shoulder power tooltip, which often led to questions, to explain that it's not an error or bad setting that must be fixed

Minor:

  • removed soft limits that matched hard ones
  • gboolean defaults shouldn't be 0.f and 1.f and min/max make no sense
  • colour -> color

This PR replaces #19745

@TurboGit
Copy link
Member

@kofa73 : This is too big for 5.4.1 and also contains strings changes which cannot be integrated into 5.4.1.

Would it be possible to extract from this the fixes, if I'm not mistaken those are:

TIA.

@TurboGit TurboGit added this to the 5.6 milestone Jan 10, 2026
@TurboGit TurboGit added bugfix pull request fixing a bug feature: redesign current features to rewrite labels Jan 10, 2026
@kofa73
Copy link
Contributor Author

kofa73 commented Jan 10, 2026

OK, I'll extract those into a separate PR tomorrow. Thanks for the feedback.
I consider this also to be a fix:

primaries selection remains visible even when "disable adjustments" is checked (disable adjustments is about rotations and in/outset, not about the base primary)

@kofa73
Copy link
Contributor Author

kofa73 commented Jan 10, 2026

#20122 for 5.4.1

@TurboGit
Copy link
Member

TurboGit commented Feb 9, 2026

Needs conflict resolution. TIA.

@kofa73
Copy link
Contributor Author

kofa73 commented Feb 11, 2026

Resolved and pushed, but I haven't had time to re-test. I'll try to do that before the end of the week.

@kofa73 kofa73 changed the title AgX refactoring and preset changes Draft: AgX refactoring and preset changes Feb 11, 2026
@kofa73 kofa73 marked this pull request as draft February 11, 2026 21:42
…reset or a preset is loaded, the 'primaries' controls remain hidden even though the checkbox is unchecked and the primaries take effect.
@kofa73 kofa73 marked this pull request as ready for review February 12, 2026 18:42
@kofa73
Copy link
Contributor Author

kofa73 commented Feb 12, 2026

Tested. Also caught and fixed a bug (introduced with the previous set of GUI changes). @dterrahe, I'd be grateful if you could please double-check the last commit: the intention is to restore the visibility of the primaries controls if they are hidden by ticking the 'disable adjustments' checkbox, and then resetting the module / loading a preset.

@kofa73 kofa73 changed the title Draft: AgX refactoring and preset changes AgX refactoring and preset changes Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix pull request fixing a bug feature: redesign current features to rewrite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Agx module makes window too big

2 participants