Control and gui starting (renamed)

[jenshannoschwalm]

EDITED for latest commits

1. Manually reverts Avoid control threads race condition Avoid control threads race condition #20002
2. control->last_expose_time was not used at all so it got removed.
3. Don't clear *gui struct again

[jenshannoschwalm]

@wpferguson would you be able to test for #19992
@dterrahe you absolutely convinced me :-) Would you review ?

[gi-man]

It's still crashing for me. Before this PR I noticed that sometimes dt starts one time, but after that it will crash every single start.

[jenshannoschwalm]

Thanks for feedback! What do you mean with crashing exactly? No window appearing without further notice in the logs?

[dterrahe]

Apologies; I had a couple of pending comments lined up as in the other PR, but as usual forgot to press the "Finish your review" button.

[TurboGit]

A minor change.

Also, given the last comment that this seems to not fix the splash issue I suppose we want this in 5.6 but not in 5.4.1. Right?

[gi-man]

Thanks for feedback! What do you mean with crashing exactly? No window appearing without further notice in the logs?

Sorry for the late reply. Dt starts but as soon as the GUI tries to start, it just keeps a spinning blue circle. Nothing new in the logs after that point. There is an X close button on the top right. When press it, Windows tells me that the app crashed and it closes everything. Log remains the same.

[jenshannoschwalm]

latest commit a) keeps the thread naming as useful in crash logs b) use dt_ atomic instruction where correct

[jenshannoschwalm]

@TurboGit this is ready to go from my side, all 3 commits have been cleaned and changes are as minimal as possible.