Update #iop-module-name font-family for Windows user readability#20090
Open
gi-man wants to merge 2 commits intodarktable-org:masterfrom
Open
Update #iop-module-name font-family for Windows user readability#20090gi-man wants to merge 2 commits intodarktable-org:masterfrom
gi-man wants to merge 2 commits intodarktable-org:masterfrom
Conversation
Add more font family names to address rendering issues on Windows with the small font size Increase from 0.8em to 0.85em
Member
Contributor
Author
|
I know it will be a compromise. What if the color of the font is lighter? |
Member
Maybe, not sure. The 0.85 also add in width about 1 character for the I'm a bit uneasy to break something working just for Windows. |
Contributor
Author
|
I will test different options to comeback before 5.4.1 |
Contributor
Author
Collaborator
1 task
Changed the font-weight to normal Added color to grey 70% so it is not too bold text Reverted the size back to 0.80em
Contributor
Author
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





A number of Windows user shared that the font is barely legible. This commits tries to find a compromise without making the font too large or bright.
Add more font family names to address rendering issues on Windows with the small font size
Increase from 0.8em to 0.85em
This is only a bug fix for 5.4.1. While investigating this, I noticed inconsistencies in how we are declaring the font-family that I will address in 5.6. Some of these include: "Arial Unicode MS" is no longer available in Windows, the sans-serif should be the last item in the list so it is a fallback instead of the first.