-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix color management issue on windows #20054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Ok, it's updated. |
TurboGit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there :) TIA.
|
@wpferguson : Would you be able to double check this on your Windows build before I merge? Nothing urgent as the merge windows for 5.6 will be open around Jan 19 at best. |
|
@TurboGit I built and it works fine AFAIC see. I can't spin up a second monitor from my VM (maybe libvirt is too old, or I haven't found the correct instructions yet). I could throw the build out on pixls.us and ask for testers. |
Good idea yes. Thanks. |
|
Before i created the PR i tested the original commit (on different system as i use linux). |
|
@Dannny1 : That's reassuring, but when a tricky feature like this is introduced and one that I cannot test myself (I'm not using Windows), I always ask for double checking. |
This is just taken from git-db-usr@262b8a6
Since nobody has created PR from it before, i will just open one.