Skip to content

Conversation

@Dannny1
Copy link

@Dannny1 Dannny1 commented Jan 1, 2026

This is just taken from git-db-usr@262b8a6
Since nobody has created PR from it before, i will just open one.

@TurboGit TurboGit added this to the 5.6 milestone Jan 2, 2026
@TurboGit TurboGit added scope: windows support windows related issues and PR bugfix pull request fixing a bug release notes: pending labels Jan 2, 2026
@Dannny1
Copy link
Author

Dannny1 commented Jan 3, 2026

Ok, it's updated.

Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there :) TIA.

@TurboGit
Copy link
Member

TurboGit commented Jan 6, 2026

@wpferguson : Would you be able to double check this on your Windows build before I merge? Nothing urgent as the merge windows for 5.6 will be open around Jan 19 at best.

@wpferguson
Copy link
Member

@TurboGit I built and it works fine AFAIC see. I can't spin up a second monitor from my VM (maybe libvirt is too old, or I haven't found the correct instructions yet). I could throw the build out on pixls.us and ask for testers.

@TurboGit
Copy link
Member

TurboGit commented Jan 7, 2026

I could throw the build out on pixls.us and ask for testers.

Good idea yes. Thanks.

@Dannny1
Copy link
Author

Dannny1 commented Jan 8, 2026

Before i created the PR i tested the original commit (on different system as i use linux).
It was able to get and use the profile. Even when profile was changed in OS during dt already running, after it was moved to different monitor it used correct profile. Entries from log on that computer:
_```
14.9156 [color profile] we got a new screen profile ROG XG279Q_d65_22-05-2023.icm' from the windows color profile api (size: 20412) 126.3981 [color profile] we got a new screen profile M16native_22-05-2023.icm' from the windows color profile api (size: 20552)
164.9649 [color profile] we got a new screen profile `ROG XG279Q_d65_22-05-2023.icm' from the windows color profile api (size: 20412)
256.3814 [color profile] we got a new screen profile `ROG XG279Q_user_p3_22-05-2023.icm' from the windows color profile api (size: 11984)
256.6663 [color profile] we got a new screen profile `M16native_22-05-2023.icm' from the windows color profile api (size: 20552)
258.4953 [color profile] we got a new screen profile `ROG XG279Q_user_p3_22-05-2023.icm' from the windows color profile api (size: 11984)

@TurboGit
Copy link
Member

TurboGit commented Jan 8, 2026

@Dannny1 : That's reassuring, but when a tricky feature like this is introduced and one that I cannot test myself (I'm not using Windows), I always ask for double checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix pull request fixing a bug release notes: pending scope: windows support windows related issues and PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants