fix export overwrite if changed #20015
Draft
+27
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function now checks against the exported file's modification time stamp instead of the export time stamp in the database. This makes a lot more sense especially when using the multi-preset export with different formats in multiple directories.
zisoft
force-pushed
the
fix-overwrite-if-changed
branch
from
44c4c99 to
dc9429d
Compare
|
hi @zisoft , thanks for your help : I will check tomorrow on the next nightly build. |
Collaborator
Author
|
@DaveInDev: This is only included in the nightly build after the PR is merged. |
|
@zisoft I'm not familiar with github. Do you mean that it won't appear in tomorrow's build ? Is there another way to test this change ? |
Member
|
Given the comment: #19987 (comment) I'll pass this as draft. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function now checks against the exported file's modification time stamp instead of the export time stamp in the database. This makes a lot more sense especially when using the multi-preset export with different formats in multiple directories.
See #15404 (comment) and #19987 (comment)