Fix multi-line function parsing in dependency analyzer #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve the .parse_function() function to better handle function calls that span multiple lines with arguments. The previous implementation used deparse() which was problematic for multi-line function calls. Changes: - Add explicit handling for function calls with `is.call(x) && length(x) >= 1` - Capture function names and recursively parse arguments to find nested calls - Add proper symbol handling with `is.symbol(x)` - Remove problematic deparse() fallback that couldn't handle multi-line calls - Filter out empty results with `out[nzchar(out)]` - Add length check for safety in $ operator handling This allows the project visualizer to correctly identify dependencies in functions with complex multi-line argument structures. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the .parse_function() function to better handle function calls that span multiple lines with arguments. The previous implementation used deparse() which was problematic for multi-line function calls.
Changes:
is.call(x) && length(x) >= 1is.symbol(x)out[nzchar(out)]This allows the project visualizer to correctly identify dependencies in functions with complex multi-line argument structures.
🤖 Generated with Claude Code