Add a new name resolution method: structuredformat #4085
Conversation
Signed-off-by: seal90 <578935869@qq.com>
Signed-off-by: seal90 <578935869@qq.com>
…contrib into config-string
mikeee
left a comment
mikeee
left a comment
There was a problem hiding this comment.
Looking good to me, could you please open up a docs PR?
Cheers!
|
Will do — I’ll open a docs PR . |
|
I've opened the docs PR — thanks for the review! |
sicoyle
left a comment
sicoyle
left a comment
There was a problem hiding this comment.
few comments so far. Can you also look at all the struct fields added and make them unexported by default where applicable please? Thank you for your contribution!! 🙌
| IPV4 string `json:"ipv4" yaml:"ipv4"` | ||
| IPV6 string `json:"ipv6" yaml:"ipv6"` | ||
| Port int `json:"port" yaml:"port"` | ||
| ExtendedInfo map[string]string `json:"extendedInfo" yaml:"extendedInfo"` |
There was a problem hiding this comment.
what do you intend extendedInfo to be used for? If we don't use it then can you pls rm it here?
| type structuredFormatMetadata struct { | ||
| StructuredType string | ||
| StringValue string | ||
| FilePath string | ||
| } |
There was a problem hiding this comment.
can you pls add a metadata.yaml file denoting which fields are required, defaults set, etc. You can reference the other components metadata.yaml files for this :)
There was a problem hiding this comment.
I read the docs PR and these fields seem different to me unless I am missing something. Can you please confirm they match after you make your updates 🙏 Also, please note that in the metadata.yaml file there is an allowedValues key you can specify to denote the diff options (ie yaml or json)
3 participants
Description
Add a new name resolution method: structuredformat.
Service invocation can be configured with just a simple text-based configuration.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[4084]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
Note: We expect contributors to open a corresponding documentation PR in the dapr/docs repository. As the implementer, you are the best person to document your work! Implementation PRs will not be merged until the documentation PR is opened and ready for review.