chore: Fetch latest version from the image registry and not from github#1615
Open
acroca wants to merge 2 commits intodapr:masterfrom
Open
chore: Fetch latest version from the image registry and not from github#1615acroca wants to merge 2 commits intodapr:masterfrom
acroca wants to merge 2 commits intodapr:masterfrom
Conversation
Member
Author
|
Waiting for #1613 to upgrade Go and golangci-lint |
acroca
force-pushed
the
versions-from-image-registry
branch
from
af55e87 to
c4ff54c
Compare
Signed-off-by: Albert Callarisa <albert@diagrid.io>
acroca
force-pushed
the
versions-from-image-registry
branch
from
c4ff54c to
6439f14
Compare
There was a problem hiding this comment.
Pull request overview
This PR changes how the CLI determines the “latest” Dapr runtime/dashboard versions, switching from GitHub/Helm-based lookups to querying container image tags directly from a registry (especially when --image-registry is provided), aiming to avoid GitHub network calls.
Changes:
- Replace GitHub/Helm version discovery with registry tag listing via
go-containerregistry. - Update standalone + Kubernetes init flows to use registry-derived latest versions.
- Update unit/e2e tests and add new dependency (
go-containerregistry) plus module tidy updates.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
pkg/version/version.go |
Implements latest-version resolution by listing image tags from a registry; adds default image refs + helpers. |
pkg/standalone/standalone.go |
Uses registry-derived latest versions for standalone init when latest is requested. |
pkg/kubernetes/kubernetes.go |
Uses registry-derived latest versions for Helm installs, respecting ImageRegistryURI. |
pkg/version/version_test.go |
Replaces GitHub/Helm tests with an in-memory OCI registry-based test suite. |
tests/e2e/standalone/init_test.go |
Updates e2e expectations for “no version specified” flows to use the new latest-version lookup. |
go.mod / go.sum |
Adds go-containerregistry and updates a set of (some unrelated) dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Albert Callarisa <albert@diagrid.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close: #1575
When providing
--image-registrythe CLI still makes http requests to github to figure out latest versions.In this PR I make it fetch the versions from the image tags from the image registry directly.