Align zcash PR workflows with n8n-style IPFS test builds#51
Merged
Conversation
Agent-Logs-Url: https://github.com/dappnode/DAppNodePackage-zcash/sessions/39b7246d-f75f-43ed-a911-c80d64711c07 Co-authored-by: Pol-Lanski <19168735+Pol-Lanski@users.noreply.github.com>
Agent-Logs-Url: https://github.com/dappnode/DAppNodePackage-zcash/sessions/39b7246d-f75f-43ed-a911-c80d64711c07 Co-authored-by: Pol-Lanski <19168735+Pol-Lanski@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update GitHub Actions workflows for IPFS comment generation
Align zcash PR workflows with n8n-style IPFS test builds
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zcash pull requests were only running a validation build, so they never produced the PR comment with the IPFS install link/hash used for test installs. This updates the workflow layout to match the working n8n pattern while keeping release automation separate and preserving the repo’s current
masterbranch strategy.PR/test build workflow
.github/workflows/build.ymlpull_requestandworkflow_dispatchactions/checkout@v4andactions/setup-node@v4with Node 20npx @dappnode/dappnodesdk github-action buildGITHUB_TOKEN,PINATA_API_KEY, andPINATA_SECRET_API_KEYRelease workflow cleanup
.github/workflows/main.ymlmain.ymlonrepository_dispatchand release-relatedpusheventsactions/checkout@v4Branch trigger consistency
.github/workflows/auto_check.ymlto usemastermain-based PR/release ambiguity from the workflow setExample of the new PR build path:
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
api.ipfs.dappnode.io/home/REDACTED/work/_temp/ghcca-node/node/bin/node node /home/REDACTED/.npm/_npx/7366de4368e80aba/node_modules/.bin/dappnodesdk build --provider remote(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
Update GitHub Actions workflows in
dappnode/DAppNodePackage-zcashso pull requests generate the same IPFS testing comment/install link behavior seen indappnode/DAppNodePackage-n8nPR #150.Context:
/ipfs/...hash for testing.DAppNodePackage-zcashonly has.github/workflows/main.ymland.github/workflows/auto_check.yml..github/workflows/main.ymlrunsnpx @dappnode/dappnodesdk build --provider remote, which appears to be only a plain validation build.DAppNodePackage-n8n, there is a dedicated.github/workflows/build.ymltriggered onpull_requestthat runsnpx @dappnode/dappnodesdk github-action buildwithGITHUB_TOKEN,PINATA_API_KEY, andPINATA_SECRET_API_KEY. That repo’s PR #150 received the expected bot comment with install link and IPFS hash.Requested work:
masterindappnode/DAppNodePackage-zcash..github/workflows/build.ymlfor PR/test builds.actions/checkout@v4andactions/setup-node@v4withnode-version: 20.npx @dappnode/dappnodesdk github-action build.GITHUB_TOKEN,PINATA_API_KEY, andPINATA_SECRET_API_KEY.pull_requestand can also be manually triggered..github/workflows/main.ymlso it is consistent with the new setup. Prefer the cleaner split where PR builds are handled bybuild.ymland release logic stays inmain.yml, avoiding duplicate PR build jobs. Preserve existing release behavior..github/workflows/auto_check.ymland keep branch naming consistent with the repo’s current branching strategy (masterunless there is already an existingmainbranch to support as well).Important constraints:
masterfor now.The following is the prior conversation context from the user's chat exploration (may be truncated):
User: why did this not generate an IPFS hash for testing like this one: @dappnode/DAppNodePackage-n8n/pull/150
in the n8n PR appears as a comment from github actions with an install link and a hash.
Assistant: It didn’t generate the IPFS hash comment because the zcash repo is missing the PR build workflow that pins the test build and comments the install link.
The key difference is:
.github/workflows/build.ymlthat runs onpull_requestand executes:npx @dappnode/dappnodesdk github-action buildPINATA_API_KEYandPINATA_SECRET_API_KEYBy contrast, zcash does not have
build.yml. Its PR workflow is only in.github/workflows/main.yml, and the PR job runs:That job only does a build test. It does not pass Pinata secrets, and it does not use the
github-action buildcommand that appears to be responsible for posting the PR comment.Meanwhile n8n has this:
And PR #150 in n8n did in fact receive the bot comment with the IPFS install link/hash.
Also, in zcash PR #50 there are currently 0 PR comments, while n8n PR #150 has the GitHub Actions comment with the install link and
/ipfs/...hash.So the likely answer is:
This pull request was created from Copilot chat.