fix: propagate P2P_PORT and QUIC_PORT as ENV in Dockerfile#61
Merged
Conversation
lodekeeper
force-pushed
the
fix/quic-port-env
branch
2 times, most recently
from
1f19a40 to
0a9ffb9
Compare
lodekeeper
changed the title
Build args P2P_PORT and QUIC_PORT from docker-compose were not declared as ARG/ENV in the Dockerfile, so they were unavailable at container runtime. This caused --quicPort= to be passed as empty which crashes Lodestar. Add ARG + ENV declarations for both ports, matching the pattern used by other consensus client packages (Lighthouse, Prysm, Teku).
lodekeeper
force-pushed
the
fix/quic-port-env
branch
from
0a9ffb9 to
6add4aa
Compare
lodekeeper
changed the title
nflaig
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI is failing since QUIC PR #59 was merged. The beacon-chain container crash-loops and never starts, causing the attestation test to time out.
P2P_PORTandQUIC_PORTare defined as docker-compose buildargsbut never declared asARG/ENVin the Dockerfile, so they're unavailable at container runtime. This causes--quicPort=(empty) to be passed to Lodestar which crashes on startup.Fix
Add
ARG+ENVdeclarations for bothP2P_PORTandQUIC_PORTin the Dockerfile, matching the pattern used by other consensus client packages (Lighthouse, Prysm, Teku).CI Timeline
97efa5d(v1.41.0 bump, 20:39 UTC) — passed, release createdf264edb(QUIC PR Enable quic #59, 21:12 UTC) — beacon container never startsf530f69(retry, 22:01 UTC) — same failure