Feature: Support for clip-path#1562
Open
CaptainDario wants to merge 11 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to make this package render the following HTML correctly.
HTML
Comparison
This PR's goal
Add CSS
clip-pathsupportImplements the CSS
clip-pathinline style property for bothflutter_widget_from_html_coreand thefwfh_svgextension package.What's supported
All standard CSS basic-shape functions:
polygon()clip-path: polygon(0% 0%, 100% 0%, 50% 100%)View
<div style="width: 100px; height: 100px; background: #E91E63; clip-path: polygon(0% 0%, 100% 0%, 50% 100%);"></div>circle()clip-path: circle(50% at 50% 50%)View
<div style="width: 100px; height: 100px; background: #2196F3; clip-path: circle(50% at 50% 50%);"></div>ellipse()clip-path: ellipse(25% 40% at 50% 50%)View
<div style="width: 100px; height: 100px; background: #4CAF50; clip-path: ellipse(25% 40% at 50% 50%);"></div>inset()clip-path: inset(10% 20% round 8px)View
<div style="width: 100px; height: 100px; background: #FF9800; clip-path: inset(10% 20% round 8px);"></div>rect()clip-path: rect(10% 80% 90% 20%)View
<div style="width: 100px; height: 100px; background: #9C27B0; clip-path: rect(10% 80% 90% 20%);"></div>rect() roundclip-path: rect(10% 80% 90% 20% round 10px)View
<div style="width: 100px; height: 100px; background: #9C27B0; clip-path: rect(10% 80% 90% 20% round 10px);"></div>xywh()clip-path: xywh(10% 20% 50% 40%)View
<div style="width: 100px; height: 100px; background: #00BCD4; clip-path: xywh(10% 20% 50% 40%);"></div>xywh() roundclip-path: xywh(10% 20% 50% 40% round 10px)View
<div style="width: 100px; height: 100px; background: #00BCD4; clip-path: xywh(10% 20% 50% 40% round 10px);"></div>nonenoneView
<div style="width: 100px; height: 100px; background: #795548; clip-path: none;"></div>path()(svg not loaded)clip-path: path("M 50 5 L 61 35 L 95 35 L 68 57 L 79 91 L 50 70 L 21 91 L 32 57 L 5 35 L 39 35 Z")View
<div style="width: 100px; height: 100px; background: #000; clip-path: path('M 50 5 L 61 35 L 95 35 L 68 57 L 79 91 L 50 70 L 21 91 L 32 57 L 5 35 L 39 35 Z');"></div>path()(svg loaded)clip-path: path("M 50 5 L 61 35 L 95 35 L 68 57 L 79 91 L 50 70 L 21 91 L 32 57 L 5 35 L 39 35 Z")View
<div style="width: 100px; height: 100px; background: #000; clip-path: path('M 50 5 L 61 35 L 95 35 L 68 57 L 79 91 L 50 70 L 21 91 L 32 57 L 5 35 L 39 35 Z');"></div>Architecture
StyleClipPathbuild op inpackages/core/lib/src/internal/ops/style_clip_path.dartfollows the same pattern asStyleBackground: it registers viaparseStyle, caches parsed state per element withsetNonInherited<_StyleClipPathData>, and wraps the rendered widget inClipPathinsideonRenderBlock.CssClipPathClipper.getClip(Size).BoxModel.clipPathsits betweenbackgroundandmargin.WidgetFactoryhooks:buildClipPath()(overridable default wraps withClipPath) andbuildClipPathFromSvgData()(default returnsnull; overridden bySvgFactory).SVG path() integration
clip-path: path("M 0 0 L …")is handled via thepath_parsingpackage (transitively included infwfh_svg, now an explicit dependency).SvgFactoryoverridesbuildClipPathFromSvgData()to parse the SVG path data at render time. WithoutSvgFactoryloaded,path()is silently ignored and the element is left unclipped.Not implemented
url(#id)references — would require SVG fragment lookupgeometry-boxkeywords (border-box,padding-box, etc.)Closes
#1505