This repository was archived by the owner on Dec 6, 2022. It is now read-only.
Update route.php to support php 8.1#135
Closed
Pok4 wants to merge 1 commit intodannyvankooten:masterfrom
Pok4:master
Closed
Update route.php to support php 8.1#135Pok4 wants to merge 1 commit intodannyvankooten:masterfrom Pok4:master
Pok4 wants to merge 1 commit intodannyvankooten:masterfrom
Pok4:master
Conversation
I update this to make the custom parameters work on php 8.1
Author
|
The changes are for 1.2alpha
-->
|
Author
|
I get a second error: PHP Warning: in file C:/xampp2/htdocs/vendor/dannyvankooten/php-router/src/Router.php on line 124: preg_match_all(): Compilation failed: invalid range in character class at offset 5 They already make a changes - #127 i already edit the files with this changes, i tested everything on php 8.1 and its working... Please, make the changes to the repo.. I'm completely newbie with github, this is my first pull request... |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I update this to make the custom parameters work on php 8.1
Without this modification custom parameters not working on php 8.1, please make the changes :)
PS: As i said, the changes is for 1.2.0 alpha