Skip to content

Fix #11335 FN arrayIndexOutOfBounds with array of pointers (regression) #8323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrchr-github wants to merge 2 commits into
base: main
Choose a base branch
from
+10 −3
Open

Fix #11335 FN arrayIndexOutOfBounds with array of pointers (regression) #8323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a511b33
Update vf_common.cpp
chrchr-github Mar 11, 2026
c08008b
Update testvalueflow.cpp
chrchr-github Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions lib/vf_common.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,9 +230,7 @@ namespace ValueFlow
setTokenValue(tok->tokAt(4), std::move(value), settings);
}
} else if (Token::Match(tok2, "%var% )")) {
const Variable *var = tok2->variable();
// only look for single token types (no pointers or references yet)
if (var && var->typeStartToken() == var->typeEndToken()) {
if (const Variable *var = tok2->variable()) {
// find the size of the type
size_t size = 0;
if (var->isEnumType()) {
Expand Down
9 changes: 9 additions & 0 deletions test/testvalueflow.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1742,6 +1742,15 @@ class TestValueFlow : public TestFixture {
values = tokenValues(code, "( D )");
ASSERT_EQUALS(1U, values.size());
TODO_ASSERT_EQUALS(2 * settings.platform.sizeof_pointer, 1, values.back().intvalue);

code = "int f() {\n" // #11335
" int* a[2];"
" return sizeof(a);\n"
"}";
values = tokenValues(code, "( a");
ASSERT_EQUALS(1U, values.size());
ASSERT_EQUALS(16, values.back().intvalue);
ASSERT_EQUALS_ENUM(ValueFlow::Value::ValueKind::Known, values.back().valueKind);
}

void valueFlowComma()
Expand Down
Loading