[gui] Prevent detaching from Q containers in range-based for loop#8311
Merged
firewave merged 1 commit intodanmar:mainfrom Mar 9, 2026
Merged
[gui] Prevent detaching from Q containers in range-based for loop#8311firewave merged 1 commit intodanmar:mainfrom
firewave merged 1 commit intodanmar:mainfrom
Conversation
Contributor
Author
|
There are some more possible detachments, but they need temporary variables. |
gruenich
force-pushed
the
feature/qAsConst-prevent-detach
branch
2 times, most recently
from
8dc86f4 to
1dfc753
Compare
Collaborator
|
Thanks for your contribution. Please use |
gruenich
force-pushed
the
feature/qAsConst-prevent-detach
branch
from
1dfc753 to
c2ede85
Compare
Use internal utils::as_const Found by Clazy (range-loop-detach).
gruenich
force-pushed
the
feature/qAsConst-prevent-detach
branch
from
c2ede85 to
e5a2cd8
Compare
|
Collaborator
|
For reference: https://github.com/KDE/clazy/blob/master/docs/checks/README-range-loop-detach.md. Unfortunately it is not very explanatory. But I came across the following which goes into much detail: https://www.kdab.com/blog-qasconst-and-stdas_const (spoiler - it prevents unwanted copies). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use utils::as_const
Found by Clazy (range-loop-detach).