Skip to content

refs #10765/#11262 - Token: introduced cache for isMutableExpression() calls #8145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
firewave wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refs #10765/#11262 - Token: introduced cache for isMutableExpression() calls #8145

firewave wants to merge 2 commits into from
+19 −9

Conversation

@firewave
Copy link
Collaborator

@firewave firewave commented Jan 21, 2026

No description provided.

@firewave
Copy link
Collaborator Author

firewave commented Jan 21, 2026 •
edited
Loading

This also gets rid of the Clang-only hack I introduced a while ago.

Using the code from https://trac.cppcheck.net/ticket/10765#comment:4:
Clang 21 - 2,713,071,190 -> 2,616,154,402
GCC 15 - 2,918,649,065 -> 2,718,303,437

Running it on https://github.com/firewave/mame_regtest/blob/master/mame_regtest.c :
Clang 21 - 20,959,594,045-> 20,008,068,513
GCC 15 - 22,603,210,883 -> 20,663,260,243

There is newly introduced overhead in Token::isMutableExpr() (about 2% of Ir).

@firewave firewave mentioned this pull request Jan 21, 2026
Closed
@firewave
Copy link
Collaborator Author

firewave commented Jan 21, 2026

Appears to have a massive impact on the CI.

Before:
Check time: cli/cmdlineparser.cpp: 40m 55.757s

After:
Check time: cli/cmdlineparser.cpp: 23m 17.996s

@firewave
Copy link
Collaborator Author

firewave commented Jan 21, 2026

No differences with #7800.

@firewave firewave marked this pull request as ready for review January 21, 2026 20:12
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 21, 2026
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 21, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

chrchr-github
chrchr-github reviewed Jan 23, 2026
View reviewed changes
lib/token.h
std::unique_ptr<SmallVector<ReferenceToken>> mRefs;
std::unique_ptr<SmallVector<ReferenceToken>> mRefsTemp;

std::int8_t mMutableExpr{-1};
Copy link
Collaborator

@chrchr-github chrchr-github Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An explanatory comment here or on isMutableExpr() would be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrchr-github chrchr-github chrchr-github left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@firewave @chrchr-github