Fix #14317 Syntax error using macro inside ifdef block

[ceJce]

Changed so that auto-configured values (without specified values) are set to itself instead of 1.

From issue 14317

isless=islesss

instead of
isless=1

[danmar]

I would expect that we test this in some way.

[chrchr-github]

This needs to be fixed in simplecpp, probably here:
const std::string rhs(eq==std::string::npos ? std::string("1") : macrostr.substr(eq+1));
https://github.com/danmar/simplecpp/blob/6d45cd7bf7f12878ed99a5dcf5ee410ef6492a4a/simplecpp.cpp#L3343

[danmar]

This needs to be fixed in simplecpp, probably here:

I am not sure. Then what happens if user executes cppcheck like this:

cppcheck -DX test.c

-DX should work the same as -DX=1 imho.

[danmar]

hmm.. the fix seems to work when I test it quickly. but is in wrong repo.

[ceJce]

This needs to be fixed in simplecpp, probably here: const std::string rhs(eq==std::string::npos ? std::string("1") : macrostr.substr(eq+1)); https://github.com/danmar/simplecpp/blob/6d45cd7bf7f12878ed99a5dcf5ee410ef6492a4a/simplecpp.cpp#L3343

The solution did not work, so I'm working on a new solution.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[chrchr-github]

This raises the question, do we want to print A=A when it was just A before? @danmar

[danmar]

Yes that is a question. I think it's good to explicitly show that A=A expansion is used. And the "=1" is not wrong to show but it's redundant.

When configuring the defines in the GUI project file dialog, "A;B" means that A and B will be 1. While "A=A;B" would mean that A macro will get value "A" and B macro would get value "1". As far as I know this is how it worked from the beginning.