Skip to content

Update to Ember 3.15 and Node 12.14 #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hemphill wants to merge 1 commit into
base: master
Choose a base branch
from
+16 −14
Open

Update to Ember 3.15 and Node 12.14 #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:12.13.0
FROM node:12.14.0
MAINTAINER Dan Lynn <docker@danlynn.org>

# ember server on port 4200
Expand Down Expand Up @@ -58,4 +58,4 @@ RUN \

# install ember-cli
RUN \
npm install -g ember-cli@3.14.0
npm install -g ember-cli@3.15.0
26 changes: 14 additions & 12 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,15 @@ This image contains everything you need to have a working development environmen

![stars](https://img.shields.io/docker/stars/danlynn/ember-cli.svg) ![pulls](https://img.shields.io/docker/pulls/danlynn/ember-cli.svg) ![automated](https://img.shields.io/docker/automated/danlynn/ember-cli.svg) ![automated](https://img.shields.io/docker/build/danlynn/ember-cli.svg) ![MIT License](https://img.shields.io/github/license/mashape/apistatus.svg)

`ember-cli 3.14.0 + node 12.13.0/13.1.0 + npm 6.12.0/6.12.1 + bower 1.8.8 + yarn 1.19.1 + chrome 78.0.3904.108 + watchman 4.9.0`
`ember-cli 3.15.0 + node 12.14.0/13.5.0 + npm 6.13.4/6.13.4 + bower 1.8.8 + yarn 1.21.1 + chrome 79.0.3945.88 + watchman 4.9.0`


### Supported tags and respective `Dockerfile` links

+ [`3.14.0`,`3.14.0-node_12.13`,`latest` (3.14.0/Dockerfile)](https://github.com/danlynn/ember-cli/blob/3.14.0/Dockerfile)
+ [`3.14.0-node_13.1` (3.14.0-node_13.1/Dockerfile)](https://github.com/danlynn/ember-cli/blob/3.14.0-node_12.10/Dockerfile)
+ [`3.15.0`,`3.15.0-node_12.14`,`latest` (3.15.0/Dockerfile)](https://github.com/danlynn/ember-cli/blob/3.15.0/Dockerfile)
+ [`3.15.0-node_13.5` (3.15.0-node_13.5/Dockerfile)](https://github.com/danlynn/ember-cli/blob/3.15.0-node_13.5/Dockerfile)
+ [`3.14.0`,`3.14.0-node_12.13` (3.14.0/Dockerfile)](https://github.com/danlynn/ember-cli/blob/3.14.0/Dockerfile)
+ [`3.14.0-node_13.1` (3.14.0-node_13.1/Dockerfile)](https://github.com/danlynn/ember-cli/blob/3.14.0-node_13.1/Dockerfile)
+ [`3.13.0`,`3.13.0-node_10.16` (3.13.0/Dockerfile)](https://github.com/danlynn/ember-cli/blob/3.13.0/Dockerfile)
+ [`3.13.0-node_12.10` (3.13.0-node_12.10/Dockerfile)](https://github.com/danlynn/ember-cli/blob/3.13.0-node_12.10/Dockerfile)
+ [`3.12.0`,`3.12.0-node_10.16` (3.12.0/Dockerfile)](https://github.com/danlynn/ember-cli/blob/3.12.0/Dockerfile)
Expand Down Expand Up @@ -144,15 +146,15 @@ You can ignore docker-compose completely and simply use straight docker commands

### Command Usage for `docker run`

Basically put `docker run --rm -ti -v $(pwd):/myapp danlynn/ember-cli:3.14.0` before any command you run.
Basically put `docker run --rm -ti -v $(pwd):/myapp danlynn/ember-cli:3.15.0` before any command you run.

Example:

```
$ docker run --rm -ti -v $(pwd):/myapp danlynn/ember-cli:3.14.0 npm install
$ docker run --rm -ti -v $(pwd):/myapp danlynn/ember-cli:3.14.0 bower --allow-root install bootstrap
$ docker run --rm -ti -v $(pwd):/myapp danlynn/ember-cli:3.14.0 ember generate model user
$ docker run --rm -ti -v $(pwd):/myapp -p 4200:4200 -p 7020:7020 -p 7357:7357 danlynn/ember-cli:3.14.0
$ docker run --rm -ti -v $(pwd):/myapp danlynn/ember-cli:3.15.0 npm install
$ docker run --rm -ti -v $(pwd):/myapp danlynn/ember-cli:3.15.0 bower --allow-root install bootstrap
$ docker run --rm -ti -v $(pwd):/myapp danlynn/ember-cli:3.15.0 ember generate model user
$ docker run --rm -ti -v $(pwd):/myapp -p 4200:4200 -p 7020:7020 -p 7357:7357 danlynn/ember-cli:3.15.0
```

Note that the `--rm` prevents a bunch of stopped containers from accumulating from these one-off commands. They take up space and since pretty much any change made by these commands will only affect what is in your project dir (/myapp in the container), there is no need to keep them around.
Expand All @@ -164,7 +166,7 @@ You could simply launch into a bash shell and execute the commands in the normal
```
$ mkdir new_ember_app
$ cd new_ember_app
$ docker run --rm -it -v $(pwd):/myapp -p 4200:4200 -p 7020:7020 -p 7357:7357 danlynn/ember-cli:3.14.0 bash
$ docker run --rm -it -v $(pwd):/myapp -p 4200:4200 -p 7020:7020 -p 7357:7357 danlynn/ember-cli:3.15.0 bash

root@9ad4805d2b50:/myapp# ember init
root@9ad4805d2b50:/myapp# ember init --yarn
Expand Down Expand Up @@ -321,20 +323,20 @@ Launch ember server (unchanged):

```
OLD: $ docker run -ti --rm -v $(pwd):/myapp -p 4200:4200 -p 7020:7020 danlynn/ember-cli:2.9.1
NEW: $ docker run -ti --rm -v $(pwd):/myapp -p 4200:4200 -p 7020:7020 danlynn/ember-cli:3.14.0
NEW: $ docker run -ti --rm -v $(pwd):/myapp -p 4200:4200 -p 7020:7020 danlynn/ember-cli:3.15.0

```

Run ember tests:

```
OLD: $ docker run -ti --rm -v $(pwd):/myapp danlynn/ember-cli:2.9.1 test
NEW: $ docker run -ti --rm -v $(pwd):/myapp danlynn/ember-cli:3.14.0 ember test
NEW: $ docker run -ti --rm -v $(pwd):/myapp danlynn/ember-cli:3.15.0 ember test
```

Launch bash shell:

```
OLD: $ docker run -ti --rm -v $(pwd):/myapp --entrypoint=/bin/bash danlynn/ember-cli:2.9.1
NEW: $ docker run -ti --rm -v $(pwd):/myapp danlynn/ember-cli:3.14.0 bash
NEW: $ docker run -ti --rm -v $(pwd):/myapp danlynn/ember-cli:3.15.0 bash
```