Detach lifecycle span from L.Context()#64
Closed
danielorbach wants to merge 1 commit into
Closed
Conversation
This attempt keeps a long-lived lifecycle span on L but stops propagating it through l.Context(), so spans started from l.Context() are roots of bounded per-handler traces. L.Span() exposes the lifecycle span; loader opts back into nesting via trace.ContextWithSpan(l.Context(), l.Span()). Saved as reference; the long-lived span itself remains an open issue and the next attempt explores eliminating it entirely.
Owner
Author
|
Preserved as a reference for the discussion on #63. Not for merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR preserves the first attempt at resolving #56 as a reference. It is opened as a draft and closed immediately; the goal is a persistent GitHub URL the merged PR can cite.
The attempt detaches the lifecycle span from
l.Context()so handler-derived spans become roots, but keeps the lifecycle span itself open for the duration of the component.L.Span()exposes the span for callers that want to record onto it (loader'sClaim.Exec) or use itsSpanContextas a span link target. The shape was abandoned in favor of dropping the long-lived span entirely; the trade-offs that drove the change are captured in the discussion on the merged PR.Not for review. Not for merge.