Session PR: Security fixes + config rename + cmd alias cleanup#197
Merged
Conversation
… writes Validate output_path in handleGenerateTemplate using filepath.Rel against the vault directory. Rejects paths that escape via ../, absolute paths outside the vault, or any traversal attempt. Closes #193
…prevent SSRF Add parse-time host validation in apitemplates.parseTemplate that checks base_url against loopback, link-local, and RFC 1918 private ranges. Rejects templates pointing at internal addresses unless allow_private: true is set. Closes #194
danieljustus
changed the title
…ible migration - Rename EnvWhitelist struct field to EnvAllowlist with new yaml tag envAllowlist - Keep EnvWhitelist as deprecated alias for backward compatibility - Add deprecation warning when envWhitelist is detected in config - Update merge logic, config keys, tests, and documentation - Add tests for both new key and backward compatibility Closes #195
Remove 25+ package-level variable aliases (var X = cli.X) from cmd/root.go. All cmd/*.go files now import internal/cli directly and use cli.X instead of the shim aliases. This completes the migration that split CLI logic into internal/cli. cmd/root.go now only contains Execute(), SetVersionInfo(), AppVersion(), and quiet-mode print helpers. Closes #196
danieljustus
changed the title
Fixes formatting in internal/config/config.go. Refs PR #197
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch session PR for 03-gh-go run.
Closes #193
Closes #194
Closes #195
Closes #196