Add biometric auth guard for critical config changes#192
Merged
Conversation
Integrate Touch ID / Face ID verification before critical configuration operations: agent tier upgrades and auth method changes. On macOS, the system biometric dialog prompts before applying the change. On platforms without biometric support, automated use requires an explicit --no-biometric flag. - New internal/authguard package with Challenger API wrapping the existing BiometricAuthenticator for re-auth prompts - agent upgrade CLI: biometric challenge before tier changes; --no-biometric flag to bypass for automation - MCP set_auth_method: biometric challenge before changing auth method when Touch ID is available - Policy ActionRequireBiometry: wired into server dispatch so biometric-requiring rules trigger a real challenge - Tests: authguard unit tests covering availability, authentication failure, and critical tool detection Closes #191
- Fix misspelling of 'canceled' in authguard test - Remove trailing punctuation from error messages - Fix String() method doc comment - Remove unused policyErr parameter from challengeBiometric Refs PR #192
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrate Touch ID / Face ID verification before critical
configuration operations: agent tier upgrades and auth method
changes. On macOS, the system biometric dialog prompts before
applying the change. On platforms without biometric support,
automated use requires an explicit --no-biometric flag.
the existing BiometricAuthenticator for re-auth prompts
--no-biometric flag to bypass for automation
auth method when Touch ID is available
so biometric-requiring rules trigger a real challenge
authentication failure, and critical tool detection
Closes #191