Skip to content

Conversation

@jameshilliard
Copy link
Contributor

Fix some issues flagged by poetry check.

Fix some issues flagged by poetry check.
jameshilliard and others added 2 commits January 14, 2025 02:04
Co-authored-by: Arun Babu Neelicattu <arun.neelicattu@gmail.com>
Co-authored-by: Arun Babu Neelicattu <arun.neelicattu@gmail.com>
@abn
Copy link
Collaborator

abn commented Jan 14, 2025

The CI Is still installing Poetry 1.8.5.

https://github.com/danielgtaylor/python-betterproto/actions/runs/12758366227/job/35583665469#step:5:142

Might need to update that in a separate PR first.

@jameshilliard jameshilliard force-pushed the fix-poetry branch 6 times, most recently from ba6692d to 8b7d1c4 Compare January 14, 2025 12:46
@jameshilliard
Copy link
Contributor Author

I think I got tests all passing now, had to drop python 3.8 support(python 3.8 is deprecated).

@abn abn merged commit f33a42b into danielgtaylor:master Jan 14, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants