fix: respect user-defined PIPX_BIN_DIR

[skycaptain]

If pipx is already installed in the base image, it's likely that PIPX_BIN_DIR is set to a custom location such as /usr/local/bin. Since this script doesn't yet support --global, this at least adds support for user-defined PIPX_BIN_DIRs. Without this support, the script would create broken symlinks, e.g. when installing ghcr.io/prulloac/devcontainer-features/pre-commit:1 and PIPX_BIN_DIR=/usr/local/bin and PIPX_HOME=/opt/pipx, pipx installs the pre-commit symlink to /opt/pipx/bin/pre-commit, which results in a broken symlink:

root ➜ / $ which pre-commit
root ➜ / $ pipx list
venvs are in /opt/pipx/venvs
apps are exposed on your $PATH at /usr/local/bin
   package pre-commit 3.8.0, installed using Python 3.11.2
    - pre-commit (symlink missing or pointing to unexpected location)

[evilhamsterman]

This project is not associated with the devcontainer project and appears to have been abandoned https://github.com/devcontainers-contrib/features/issues/628 . The official project has removed all devcontainer-contrib features from their listing. devcontainers/devcontainers.github.io#451. There is a fork that is being worked on to update and maintain the features https://github.com/devcontainers-extra/features

[skycaptain]

Thanks for the info! I appreciate it, but I haven't spotted an official word from @danielbraun89 in those discussions yet—just other folks chiming in. I'll keep this PR open for now and look into some other options while we wait for an official response. No worries!

[evilhamsterman]

There may never be a response from @danielbraun89. He appears to be based in Israel and his online activity decreased significantly about a year ago, which sadly corresponds with the beginning of the current conflict. It's been almost non existent for about 9 months.

Theses features have been removed from the official upstream containers.dev features listing so there isn't much use to trying to improve it. The fork is beginning to see lots of activity and should be listed on the website soon. If the original maintainer ever returns then the fork could merge back in, or maybe he can join the fork as a new maintainer. This is likely a dead project whatever happens. If you'd like to keep the PR open than that's fine, but I'd focus my efforts on the fork, and I'm sure your PR would be appreciated there.