Skip to content

chore: remove lodash.keys #1491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
orta merged 1 commit into from
Oct 25, 2025
Merged

chore: remove lodash.keys #1491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,6 @@
"jsonwebtoken": "^9.0.0",
"lodash.includes": "^4.3.0",
"lodash.isobject": "^3.0.2",
"lodash.keys": "^4.0.8",
"lodash.mapvalues": "^4.6.0",
"lodash.memoize": "^4.1.2",
"memfs-or-file-map-to-github-branch": "^1.3.0",
Expand Down
5 changes: 2 additions & 3 deletions source/platforms/git/gitJSONToGitDSL.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import parseDiff from "parse-diff"

import includes from "lodash.includes"
import isobject from "lodash.isobject"
import keys from "lodash.keys"
import memoize from "lodash.memoize"

import * as jsonDiff from "fast-json-patch"
Expand Down Expand Up @@ -144,8 +143,8 @@ export const gitJSONToGitDSL = (gitJSONRep: GitJSONDSL, config: GitJSONToGitDSLC
diff.removed = arrayBefore.filter((o) => !includes(arrayAfter, o))
// Do the same, but for keys inside an object if they both are objects.
} else if (isobject(afterValue) && isobject(beforeValue)) {
const beforeKeys = keys(beforeValue) as string[]
const afterKeys = keys(afterValue) as string[]
const beforeKeys = Object.keys(beforeValue) as string[]
const afterKeys = Object.keys(afterValue) as string[]
diff.added = afterKeys.filter((o) => !includes(beforeKeys, o))
diff.removed = beforeKeys.filter((o) => !includes(afterKeys, o))
}
Expand Down
5 changes: 0 additions & 5 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5189,11 +5189,6 @@ lodash.isstring@^4.0.1:
resolved "https://registry.yarnpkg.com/lodash.isstring/-/lodash.isstring-4.0.1.tgz#d527dfb5456eca7cc9bb95d5daeaf88ba54a5451"
integrity sha512-0wJxfxH1wgO3GrbuP+dTTk7op+6L41QCXbGINEmD+ny/G/eCqGzxyCsh7159S+mgDDcoarnBw6PC1PS5+wUGgw==

lodash.keys@^4.0.8:
version "4.2.0"
resolved "https://registry.yarnpkg.com/lodash.keys/-/lodash.keys-4.2.0.tgz#a08602ac12e4fb83f91fc1fb7a360a4d9ba35205"
integrity sha512-J79MkJcp7Df5mizHiVNpjoHXLi4HLjh9VLS/M7lQSGoQ+0oQ+lWEigREkqKyizPB1IawvQLLKY8mzEcm1tkyxQ==

lodash.mapvalues@^4.6.0:
version "4.6.0"
resolved "https://registry.yarnpkg.com/lodash.mapvalues/-/lodash.mapvalues-4.6.0.tgz#1bafa5005de9dd6f4f26668c30ca37230cc9689c"
Expand Down