Skip to content

Fix: Enable exception mode to skip scripts on first error #1258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
glensc wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix: Enable exception mode to skip scripts on first error #1258

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d1e2a3
Enable exception mode to skip scripts on first error
glensc Mar 18, 2022
c630686
Be consistent and use set -e in all scripts
glensc Mar 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,20 +58,20 @@
"test:watch": "jest --watch",
"lint": "eslint \"source/*.ts\" \"source/**/*.ts\"",
"lint:fix": "yarn --silent lint --fix",
"prepublishOnly": "yarn build && yarn jest && yarn declarations && yarn build:flow-types && yarn build:pretty-types",
"build": "shx rm -rf ./distribution && tsc -p tsconfig.production.json && madge ./distribution --circular",
"prepublishOnly": "set -e; yarn build; yarn jest; yarn declarations; yarn build:flow-types; yarn build:pretty-types",
"build": "set -e; shx rm -rf ./distribution; tsc -p tsconfig.production.json; madge ./distribution --circular",
"build:fast": "tsc -p tsconfig.production.json",
"build:flow-types": "cp source/danger.d.ts source/_danger.d.ts && sed -ie 's/api: GitHub/api: any/g' source/_danger.d.ts && npx flowgen@1.3.0 source/_danger.d.ts -o distribution/danger.js.flow && node scripts/update_flow_types.js",
"build:schemas": "typescript-json-schema tsconfig.json DangerJSON > source/danger-incoming-process-schema.json; typescript-json-schema tsconfig.json DangerResults > source/danger-outgoing-process-schema.json; yarn prettier --write source/danger-outgoing-process-schema.json source/danger-incoming-process-schema.json",
"build:pretty-types": "yarn prettier --write distribution/danger.d.ts; yarn prettier --parser flow distribution/danger.js.flow --write",
"build:flow-types": "set -e; cp source/danger.d.ts source/_danger.d.ts; sed -ie 's/api: GitHub/api: any/g' source/_danger.d.ts; npx flowgen@1.3.0 source/_danger.d.ts -o distribution/danger.js.flow; node scripts/update_flow_types.js",
"build:schemas": "set -e; typescript-json-schema tsconfig.json DangerJSON > source/danger-incoming-process-schema.json; typescript-json-schema tsconfig.json DangerResults > source/danger-outgoing-process-schema.json; yarn prettier --write source/danger-outgoing-process-schema.json source/danger-incoming-process-schema.json",
"build:pretty-types": "set -e; yarn prettier --write distribution/danger.d.ts; yarn prettier --parser flow distribution/danger.js.flow --write",
"build:watch": "tsc -w",
"link": "yarn run build && chmod +x distribution/commands/danger.js && yarn link",
"package": "yarn run pkg . --output brew-distribution/danger; zip -j brew-distribution/danger-macos.zip brew-distribution/danger; shasum -a 256 brew-distribution/danger-macos.zip",
"link": "set -e; yarn run build; chmod +x distribution/commands/danger.js; yarn link",
"package": "set -e; yarn run pkg . --output brew-distribution/danger; zip -j brew-distribution/danger-macos.zip brew-distribution/danger; shasum -a 256 brew-distribution/danger-macos.zip",
"declarations": "ts-node ./scripts/create-danger-dts.ts",
"docs:cp_defs": "mkdir docs/docs_generate; cp source/danger.d.ts docs/docs_generate; cp node_modules/@octokit/rest/index.d.ts docs/docs_generate/github.d.ts",
"docs": "yarn run docs:cp_defs; yarn typedoc --ignoreCompilerErrors --mode modules --json docs/js_ref_dsl_docs.json --includeDeclarations source",
"dts-lint": "yarn run declarations && yarn dtslint types",
"danger:prepush": "yarn build:fast; yarn test:fixtures; node distribution/commands/danger.js local --base main --dangerfile dangerfile.lite.ts"
"docs:cp_defs": "set -e; mkdir docs/docs_generate; cp source/danger.d.ts docs/docs_generate; cp node_modules/@octokit/rest/index.d.ts docs/docs_generate/github.d.ts",
"docs": "set -e; yarn run docs:cp_defs; yarn typedoc --ignoreCompilerErrors --mode modules --json docs/js_ref_dsl_docs.json --includeDeclarations source",
"dts-lint": "set -e; yarn run declarations; yarn dtslint types",
"danger:prepush": "set -e; yarn build:fast; yarn test:fixtures; node distribution/commands/danger.js local --base main --dangerfile dangerfile.lite.ts"
},
"repository": {
"type": "git",
Expand Down Expand Up @@ -185,7 +185,7 @@
"husky": {
"hooks": {
"pre-commit": "lint-staged",
"pre-push": "yarn build; yarn danger:prepush"
"pre-push": "set -e; yarn build; yarn danger:prepush"
}
}
}