Skip to content

Update minimum CMake version to 3.12; support CMake 4.0 #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
musicinmybrain wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update minimum CMake version to 3.12; support CMake 4.0 #82

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 2.8.11)
cmake_minimum_required(VERSION 3.12)
Copy link

@Mengna-Li Mengna-Li Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cmake_minimum_required(VERSION 3.12)
cmake_minimum_required(VERSION 3.12...3.5)
Suggested change
cmake_minimum_required(VERSION 3.12)
cmake_minimum_required(VERSION 3.12)

Copy link
Author

@musicinmybrain musicinmybrain Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m confused. The first suggestion seems to change this to a version range, but in the wrong direction (3.12...3.5 instead of 3.5...3.12), and then the second suggestion … changes it back?

If you do have a concrete reason to want to support such old CMake versions, 3.5...3.12 would be a reasonable alternative to 3.12.


if(POLICY CMP0042)
cmake_policy(SET CMP0042 NEW)
Expand Down