Skip to content

Fixed task generation for automatic mode to happen on play #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfsohail12 merged 5 commits into from
Apr 17, 2026
Merged

Fixed task generation for automatic mode to happen on play #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3e1c9d5
impl locked params when load config file
dan-moraru Apr 16, 2026
1ae1fee
fix setup controller version
dan-moraru Apr 16, 2026
f4ea753
removed auto generating tasks in SetupController to avoid disconnect …
mfsohail12 Apr 17, 2026
43bec60
fixed setup controller tests
mfsohail12 Apr 17, 2026
66e1c56
Merge branch 'dev' into auto-gen-task-on-play-only
mfsohail12 Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions open-robotics/src/main/java/com/openrobotics/controllers/SetupController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -799,11 +799,6 @@ private SimulationEngine buildEngineFromSetup() {

Dispatcher dispatcher = new Dispatcher();

// Seed the dispatcher with the initial rack-to-station workload if not in manual mode
if (!isManualMode && maxTasks > 0 && map != null) {
generateFixedTasks(map, seed, maxTasks, dispatcher);
}

String runName = runNameField.getText().trim();
if (runName.isEmpty()) runName = DEFAULT_RUN_NAME;

Expand Down
8 changes: 4 additions & 4 deletions open-robotics/src/test/java/com/openrobotics/controllers/SetupControllerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,7 +526,7 @@ void buildEngineFromSetup_uses_field_values_defaults_and_robot_config() {
assertEquals(77, engine.getMaxTicks());
assertEquals(123L, engine.getSeed());
assertTrue(engine.getCoordinationPolicy().contains(ReservationKPolicy.class.getName()));
assertEquals(4, engine.getDispatcher().getTotalTasksAdded());
assertEquals(0, engine.getDispatcher().getTotalTasksAdded());
assertEquals(150.5f, config.batteryCapacity, 0.001f);
assertEquals(35.5f, config.lowBatteryThreshold, 0.001f);
assertEquals(9.5f, config.chargePerTick, 0.001f);
Expand Down Expand Up @@ -580,7 +580,7 @@ void buildEngineFromSetup_random_map_honors_explicit_map_seed() {

assertEquals(entitySignature(first.getMap()), entitySignature(second.getMap()));
assertEquals(111L, first.getSeed());
assertEquals(3, first.getDispatcher().getTotalTasksAdded());
assertEquals(0, first.getDispatcher().getTotalTasksAdded());
assertEquals(1, countEntities(first.getMap(), ChargingStation.class));
assertEquals(1, countEntities(first.getMap(), DeliveryStation.class));
}
Expand Down Expand Up @@ -732,7 +732,7 @@ void startSimulation_builds_engine_from_setup_values_persists_config_and_navigat

assertTrue(AppState.hasEngine());
assertTrue(AppState.hasConfigPath());
assertEquals(2, AppState.getEngine().getDispatcher().getTotalTasksAdded());
assertEquals(0, AppState.getEngine().getDispatcher().getTotalTasksAdded());
assertEquals(200, AppState.getEngine().getMaxTicks());
assertNotNull(lookup("#warehouseCanvas").queryAs(Canvas.class));
}
Expand All @@ -754,7 +754,7 @@ void startSimulation_rebuilds_existing_ui_built_engine_when_no_config_path_exist
assertTrue(AppState.hasEngine());
assertTrue(AppState.hasConfigPath());
assertEquals(18, AppState.getEngine().getMap().getWidth());
assertEquals(1, AppState.getEngine().getDispatcher().getTotalTasksAdded());
assertEquals(0, AppState.getEngine().getDispatcher().getTotalTasksAdded());
assertNotNull(lookup("#warehouseCanvas").queryAs(Canvas.class));
}

Expand Down
Loading