Fix parser failure for inside expression in module-level if generate construct#123
Merged
dalance merged 2 commits intodalance:masterfrom Mar 30, 2026
Merged
Fix parser failure for inside expression in module-level if generate construct#123dalance merged 2 commits intodalance:masterfrom
inside expression in module-level if generate construct#123dalance merged 2 commits intodalance:masterfrom
Conversation
Fixes failure to parse 'if (x inside {...})' at module level.
The if_generate_construct parser uses constant_expression for the
condition, but constant_expression did not include inside_expression
as a valid alternative.
Changes:
- Add Inside variant to ConstantExpression enum
- Add ConstantInsideExpression struct with (ConstantExpression, Keyword, Brace<OpenRangeList>)
- Add constant_inside_expression parser function
- Add constant_inside_expression to constant_expression alternatives
All 68 tests pass after this change.
…struct
This test was added to demonstrate the bug where 'if (x inside {...})'
at module level failed to parse. The test now passes after the fix.
Owner
|
Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #122
Changes
constant_inside_expressionas a new variant ofconstant_expression.sv-parser-parser/src/tests.rsat line 5067.