Add fancy regex fallback for advanced filters#913
Open
sabbellasri wants to merge 2 commits intodalance:masterfrom
Open
Add fancy regex fallback for advanced filters#913sabbellasri wants to merge 2 commits intodalance:masterfrom
sabbellasri wants to merge 2 commits intodalance:masterfrom
Conversation
Contributor
Author
|
Hi @dalance, I opened PR #913 to address the lookaround support request from #905. The PR adds a small matcher wrapper that keeps Rust’s regex crate as the fast path for normal patterns and falls back to fancy-regex only when the standard engine cannot compile advanced patterns like lookaheads/lookarounds. All checks are passing, and the PR can be cleanly merged. Please let me know if you would prefer a different approach or any changes before review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a small regex matcher wrapper that keeps Rust's
regexcrate as the fast path for standard patterns, and falls back tofancy-regexwhen the fast engine cannot compile an advanced pattern such as lookaround.This enables filters like positive and negative lookahead while preserving the existing fast behavior for common regex usage.
Related to #554
Closes #905
cc @beelze
Changes
fancy-regexas a dependencySearchRegexwrapper for fast/fancy engine selectionTesting
cargo fmtcargo checkcargo testResult:
12 passed; 0 failed