Extract BinaryLocator class from Commands module #5
+33
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor binary discovery logic into a dedicated class for better separation of concerns. This improves testability and maintainability by isolating platform-specific binary resolution. # Changes - Add BinaryLocator class with find method and candidates logic - Remove find_rust_binary private method from Commands - Remove COMMANDS_DIR constant (now LIB_DIR in BinaryLocator)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor binary discovery logic into a dedicated class for better separation of concerns. This improves testability and maintainability by isolating platform-specific binary resolution.
Changes