Skip to content

fix(shared): prevent false failure toast after squad moderation succeeds#5679

Merged
idoshamun merged 4 commits intomainfrom
eng-999-when-moderating-squad-posts-toast-sometimes-shows-that-it
Mar 9, 2026
Merged

fix(shared): prevent false failure toast after squad moderation succeeds#5679
idoshamun merged 4 commits intomainfrom
eng-999-when-moderating-squad-posts-toast-sometimes-shows-that-it

Conversation

@idoshamun
Copy link
Member

@idoshamun idoshamun commented Mar 9, 2026

Summary

  • made squad moderation analytics mapping tolerant of incomplete moderation items (type/image missing)
  • prevented throws inside mutation onSuccess, so successful approve/reject flows no longer reject after the success toast
  • ensured valid items in a mixed batch still produce analytics events while invalid items are skipped
  • added focused regression tests for approve/reject flows to verify success toast path, modal closing behavior, and partial analytics logging

Key decisions

  • fixed the issue at the logging helper boundary (instead of adding .catch() at callers) to avoid masking real mutation failures
  • preserved partial analytics by filtering invalid entries rather than failing the entire batch

Closes ENG-999


Created by Huginn 🐦‍⬛

Preview domain

https://eng-999-when-moderating-squad-po.preview.app.daily.dev

@vercel
Copy link

vercel bot commented Mar 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
daily-webapp Ready Ready Preview Mar 9, 2026 11:23am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
storybook Ignored Ignored Mar 9, 2026 11:23am

Request Review

@idoshamun idoshamun merged commit 424ba67 into main Mar 9, 2026
11 checks passed
@idoshamun idoshamun deleted the eng-999-when-moderating-squad-posts-toast-sometimes-shows-that-it branch March 9, 2026 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant