fix(shared): improve dropdown scroll affordance and responsive sizing#5673
Open
tsahimatsliah wants to merge 3 commits intomainfrom
Open
fix(shared): improve dropdown scroll affordance and responsive sizing#5673tsahimatsliah wants to merge 3 commits intomainfrom
tsahimatsliah wants to merge 3 commits intomainfrom
Conversation
Add Notion-style scroll fade cues for overflowing dropdowns, make action menus easier to read, and standardize field dropdown sizing so small triggers no longer collapse menu content. Made-with: Cursor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
Author
|
Implemented branch summary:
Validation completed:
|
Adjust dropdown fade edge opacity and increase collision padding so constrained menus remain visible while keeping a safer gap from viewport edges. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useScrollFadeand wire it into sharedDropdownMenuContentfor top/bottom overflow fade indicators.--radix-dropdown-menu-content-available-height.actionandfield) to separate sizing behavior.sideOffset).24.0.24and mask logic updated so edge items remain visible.Dropdown,Select,PollDurationDropdown,MonthSelect,YearSelect,ExperienceLevelDropdown) with shared field variant behavior.Test plan
pnpm --filter shared lintPreview domain
https://fix-shared-dropdown-scroll-and-s.preview.app.daily.dev