fix: enable mobile comment pre-fill for notifications #5297
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y to footer On mobile, there are two NewComment components rendered: 1. From PostEngagements in the post content area 2. From FooterWrapper in the mobile footer (tablet:hidden) The footer component was missing the shouldHandleCommentQuery prop, which prevented it from handling the ?comment= query parameter on mobile. Desktop worked because it only uses the PostEngagements version which has the prop. This fix adds shouldHandleCommentQuery to the footer's NewComment so notifications with pre-filled comment text work correctly on mobile. Fixes #5296 Co-authored-by: Chris Bongers <rebelchris@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On mobile, there are two NewComment components rendered:
The footer component was missing the
shouldHandleCommentQueryprop, which prevented it from handling the?comment=query parameter on mobile. Desktop worked because it only uses the PostEngagements version which has the prop.This fix adds
shouldHandleCommentQueryto the footer's NewComment so notifications with pre-filled comment text work correctly on mobile.Fixes #5296
Generated with Claude Code) | View job run | [Branch](https://github.com/dailydotdev/apps/tree/claude/issue-5296-20260114-0723
Preview domain
https://claude-issue-5296-20260114-0723.preview.app.daily.dev