feat: migrate to ESM (partial) - Option B #5280
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename all config files to .cjs (14 files) - Add "type": "module" to all package.json files (9 packages) - Update references in tsconfig.eslint.json files - Update AGENTS.md documentation This implements Option B (partial migration) for ESM support: - Config files remain CommonJS (.cjs extension) - Source code ready for ESM with type: module - Minimal risk, easy rollback - No Jest upgrade required in this phase Related to #5278 Co-authored-by: Chris Bongers <rebelchris@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
When 'type: module' is set in package.json, tools like Jest and Webpack default to looking for .js config files. Since we renamed them to .cjs, we need to explicitly specify the config file paths using --config flags. Changes: - Updated package.json scripts in extension, webapp, and shared to use --config flags for jest and webpack - Updated CircleCI config to specify jest.config.cjs in all test jobs - Updated extension/AGENTS.md to reference webpack.config.cjs Co-authored-by: Chris Bongers <rebelchris@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements Option B (partial migration) for ESM support as discussed in #5278.
Changes
.cjsextension (babel, jest, postcss, webpack, eslint)"type": "module"to all 9 package.json filesBenefits
type: moduleTesting
Please verify:
Related to #5278
Generated with Claude Code
Preview domain
https://claude-issue-5278-20260112-0817.preview.app.daily.dev