Skip to content

Add Find/Replace In Selection #1045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saberoueslati wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add Find/Replace In Selection #1045

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc18399
Add Find/Replace In Selection
saberoueslati May 5, 2026
1825409
Extend Mark All to respect In Selection
saberoueslati May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
115 changes: 101 additions & 14 deletions src/Finder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,16 +46,52 @@ void Finder::setSearchText(const QString &text)
this->text = text;
}

void Finder::setSelectionRange(Sci_CharacterRange range)
{
use_selection_range = true;
selection_range = range;
}

void Finder::clearSelectionRange()
{
use_selection_range = false;
}

Sci_CharacterRange Finder::findNext(int startPos)
{
did_latest_search_wrap = false;

if (text.isEmpty())
return {INVALID_POSITION, INVALID_POSITION};

const int pos = startPos == INVALID_POSITION ? editor->selectionEnd() : startPos;
const QByteArray textData = text.toUtf8();

if (use_selection_range) {
// Clamp start position to within the selection
const int rangeEnd = selection_range.cpMax;
int pos = startPos == INVALID_POSITION ? editor->selectionEnd() : startPos;
if (pos < selection_range.cpMin) pos = selection_range.cpMin;
if (pos > rangeEnd) pos = rangeEnd;

editor->setTargetRange(pos, rangeEnd);
editor->setSearchFlags(search_flags);

if (editor->searchInTarget(textData.length(), textData.constData()) != INVALID_POSITION) {
return {static_cast<Sci_PositionCR>(editor->targetStart()), static_cast<Sci_PositionCR>(editor->targetEnd())};
}
// Wrap within selection
if (wrap && pos > selection_range.cpMin) {
editor->setTargetRange(selection_range.cpMin, pos);
if (editor->searchInTarget(textData.length(), textData.constData()) != INVALID_POSITION) {
did_latest_search_wrap = true;
return {static_cast<Sci_PositionCR>(editor->targetStart()), static_cast<Sci_PositionCR>(editor->targetEnd())};
}
}
return {INVALID_POSITION, INVALID_POSITION};
}

const int pos = startPos == INVALID_POSITION ? editor->selectionEnd() : startPos;

editor->setTargetRange(pos, editor->length());
editor->setSearchFlags(search_flags);

Expand All @@ -81,9 +117,32 @@ Sci_CharacterRange Finder::findPrev()
if (text.isEmpty())
return {INVALID_POSITION, INVALID_POSITION};

const int pos = editor->selectionStart();
const QByteArray textData = text.toUtf8();

if (use_selection_range) {
int pos = editor->selectionStart();
if (pos > selection_range.cpMax) pos = selection_range.cpMax;
if (pos < selection_range.cpMin) pos = selection_range.cpMin;

editor->setSearchFlags(search_flags);
auto range = editor->findText(search_flags, textData.constData(), pos, selection_range.cpMin);

if (range.first != INVALID_POSITION) {
return {static_cast<Sci_PositionCR>(range.first), static_cast<Sci_PositionCR>(range.second)};
}
// Wrap within selection
if (wrap && pos < selection_range.cpMax) {
range = editor->findText(search_flags, textData.constData(), selection_range.cpMax, pos);
if (range.first != INVALID_POSITION) {
did_latest_search_wrap = true;
return {static_cast<Sci_PositionCR>(range.first), static_cast<Sci_PositionCR>(range.second)};
}
}
return {INVALID_POSITION, INVALID_POSITION};
}

const int pos = editor->selectionStart();

editor->setTargetRange(pos, editor->length());
editor->setSearchFlags(search_flags);

Expand All @@ -104,17 +163,21 @@ Sci_CharacterRange Finder::findPrev()
return {INVALID_POSITION, INVALID_POSITION};
}

// Count all occurrences in the document
// Count all occurrences in the document (or selection if set)
int Finder::count()
{
int total = 0;

if (text.length() > 0) {
forEachMatch([&](int start, int end) {
auto counter = [&](int start, int end) {
Q_UNUSED(start);
total++;
return end;
});
};
if (use_selection_range)
forEachMatchInRange(counter, selection_range);
else
forEachMatch(counter);
}

return total;
Expand All @@ -123,22 +186,33 @@ int Finder::count()
Sci_CharacterRange Finder::replaceSelectionIfMatch(const QString &replaceText)
{
const QByteArray textData = text.toUtf8();
bool isRegex = editor->searchFlags() & SCFIND_REGEXP;
const bool isRegex = search_flags & SCFIND_REGEXP;
const Sci_PositionCR selectionStart = editor->selectionStart();
const Sci_PositionCR selectionEnd = editor->selectionEnd();

if (use_selection_range && (selectionStart < selection_range.cpMin || selectionEnd > selection_range.cpMax))
return {INVALID_POSITION, INVALID_POSITION};

// Search just in the selection to see if the current selection is a match
editor->setTargetStart(editor->selectionStart());
editor->setTargetEnd(editor->selectionEnd());
editor->setTargetStart(selectionStart);
editor->setTargetEnd(selectionEnd);
editor->setSearchFlags(search_flags);

if (editor->searchInTarget(textData.length(), textData.constData()) != INVALID_POSITION) {
const QByteArray replaceData = replaceText.toUtf8();
const Sci_PositionCR matchStart = editor->targetStart();
const Sci_PositionCR matchEnd = editor->targetEnd();
int replaceLength;

if (isRegex)
editor->replaceTargetRE(replaceData.length(), replaceData.constData());
replaceLength = editor->replaceTargetRE(replaceData.length(), replaceData.constData());
else
editor->replaceTarget(replaceData.length(), replaceData.constData());
replaceLength = editor->replaceTarget(replaceData.length(), replaceData.constData());

return {static_cast<Sci_PositionCR>(editor->targetStart()), static_cast<Sci_PositionCR>(editor->targetEnd())};
if (use_selection_range)
selection_range.cpMax += replaceLength - (matchEnd - matchStart);

return {matchStart, static_cast<Sci_PositionCR>(matchStart + replaceLength)};
}

return {INVALID_POSITION, INVALID_POSITION};
Expand All @@ -152,7 +226,9 @@ int Finder::replaceAll(const QString &replaceText)
const QByteArray &replaceData = replaceText.toUtf8();
const QByteArray &b = text.toUtf8();
const char *c = b.constData();
Sci_TextToFind ttf {{0, (Sci_PositionCR)editor->length()}, c, {-1, -1}};
const Sci_PositionCR rangeStart = use_selection_range ? selection_range.cpMin : 0;
Sci_PositionCR rangeEnd = use_selection_range ? selection_range.cpMax : (Sci_PositionCR)editor->length();
Sci_TextToFind ttf {{rangeStart, rangeEnd}, c, {-1, -1}};
const bool isRegex = search_flags & SCFIND_REGEXP;
int total = 0;

Expand All @@ -173,11 +249,22 @@ int Finder::replaceAll(const QString &replaceText)
else
ttf.chrg.cpMin = start + editor->replaceTarget(replaceData.length(), replaceData.constData());

// The replace could have changed the document size, so update the end of the search range
ttf.chrg.cpMax = editor->length();
// Update the end of the search range based on the length delta of this replacement.
// When confined to a selection, track the selection boundary precisely; otherwise
// expand to the full (possibly grown) document length.
if (use_selection_range) {
rangeEnd += ttf.chrg.cpMin - end; // delta = newLength - oldMatchLength
ttf.chrg.cpMax = rangeEnd;
} else {
ttf.chrg.cpMax = editor->length();
}

total++;
}

// Keep the stored selection range in sync with the post-replacement boundary
if (use_selection_range)
selection_range.cpMax = rangeEnd;

return total;
}
7 changes: 7 additions & 0 deletions src/Finder.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,10 @@ class Finder
Sci_CharacterRange replaceSelectionIfMatch(const QString &replaceText);
int replaceAll(const QString &replaceText);

void setSelectionRange(Sci_CharacterRange range);
void clearSelectionRange();
bool hasSelectionRange() const { return use_selection_range; }

template<typename Func>
void forEachMatch(Func callback) { forEachMatchInRange(callback, {0, (Sci_PositionCR)editor->length()}); }

Expand All @@ -54,6 +58,9 @@ class Finder
bool wrap = false;
int search_flags = 0;
QString text;

bool use_selection_range = false;
Sci_CharacterRange selection_range = {0, 0};
};


Expand Down
Loading