Feature/ppl udt compilation adapter#19
Draft
dai-chen wants to merge 1 commit into
Draft
Conversation
… UDF Add preCompilationRules to bridge the type mismatch between normalized standard types (DATE/TIME/TIMESTAMP as int/long) and PPL UDF implementors (which expect and produce String values): 1. DatetimeUdfCompilationAdapterRule inserts CAST nodes around datetime UDFs so implementors receive String input and produce String output, with CASTs bridging int/long <-> String conversion. 2. DatetimeUdtNormalizeRule enhanced to handle LogicalAggregate (rebuild AggregateCall with re-inferred types) and LogicalProject (refresh RexInputRef types from new child row type) to prevent type mismatch assertions when datetime UDF results feed into aggregates. Both fixes are only needed for the UnifiedQueryCompiler (Enumerable) path. The Analytics Engine (Substrait/DataFusion) path is unaffected. Signed-off-by: Chen Dai <daichen@amazon.com>
dai-chen
force-pushed
the
feature/ppl-udt-compilation-adapter
branch
from
8995649 to
7be9575
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add preCompilationRules to LanguageSpec.LanguageExtension and register DatetimeUdfCompilationAdapterRule in DatetimeExtension. The rule inserts CAST nodes to bridge the type mismatch between normalized standard types (DATE/TIME/TIMESTAMP as int/long) and PPL UDF implementors (which expect and produce String values):
Before: LAST_DAY($2:DATE) : DATE
After: CAST(LAST_DAY(CAST($2 AS VARCHAR)):VARCHAR AS DATE)
Applied only in UnifiedQueryCompiler before Enumerable code generation, so the logical plan seen by other consumers (Analytics Engine, Substrait) remains clean with standard types.
Description
[Describe what this change achieves]
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.