feat(api): Register LENGTH, REGEXP_REPLACE, DATE_TRUNC in operator table#17
Closed
dai-chen wants to merge 2 commits into
Closed
feat(api): Register LENGTH, REGEXP_REPLACE, DATE_TRUNC in operator table#17dai-chen wants to merge 2 commits into
dai-chen wants to merge 2 commits into
Conversation
dai-chen
commented
May 7, 2026
dai-chen
force-pushed
the
feature/register-scalar-functions
branch
from
e757d9e to
d5c7b6c
Compare
dai-chen
commented
May 7, 2026
Add FunctionSpecBuilder DSL with three construction paths: delegateTo() for existing Calcite operators, vararg() for pushdown-only UDFs, and operands() for typed functions with optional late-binding impl. Register LENGTH, REGEXP_REPLACE, and DATE_TRUNC in UnifiedFunctionSpec LIBRARY category. Contribute via CoreExtension registered in UnifiedSqlSpec.extended(). This unblocks ClickBench q28 (LENGTH), q29 (REGEXP_REPLACE), and q43 (DATE_TRUNC) at the SQL Plugin parsing/validation layer. Signed-off-by: Chen Dai <daichen@amazon.com>
dai-chen
force-pushed
the
feature/register-scalar-functions
branch
3 times, most recently
from
da83381 to
64816d7
Compare
dai-chen
commented
May 7, 2026
dai-chen
force-pushed
the
feature/register-scalar-functions
branch
from
64816d7 to
8829a74
Compare
dai-chen
commented
May 7, 2026
dai-chen
force-pushed
the
feature/register-scalar-functions
branch
4 times, most recently
from
73a9267 to
93dca4e
Compare
Add preCompilationRules() extension point to LanguageSpec that allows extensions to transform the logical plan before in-memory execution only. The plan remains clean for external consumers (Analytics Engine). CoreExtension registers FunctionImplBindingRule which fetches impl bindings from UnifiedFunctionSpec and rewrites custom function calls into executable Calcite expressions at compilation time. DATE_TRUNC now has an impl that rewrites to FLOOR(ts TO unit), making it executable in-memory while preserving DATE_TRUNC in the logical plan for the Analytics Engine path. Signed-off-by: Chen Dai <daichen@amazon.com>
dai-chen
force-pushed
the
feature/register-scalar-functions
branch
from
93dca4e to
6561560
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extend UnifiedFunctionSpec Builder with delegateTo() and operands() paths to support library functions backed by native Calcite operators. Add LIBRARY category with LENGTH, REGEXP_REPLACE, and DATE_TRUNC (PostgreSQL arg order). Override operatorTable() in UnifiedSqlSpec to chain these into the SQL validation pipeline.
This unblocks ClickBench q28 (LENGTH), q29 (REGEXP_REPLACE), and q43 (DATE_TRUNC) at the SQL Plugin parsing/validation layer.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.