[PoC] [BugFix] Fix BABEL isNonStrictGroupBy causing ANY_VALUE wrapping and NPE#15
Draft
dai-chen wants to merge 1 commit into
Draft
[PoC] [BugFix] Fix BABEL isNonStrictGroupBy causing ANY_VALUE wrapping and NPE#15dai-chen wants to merge 1 commit into
dai-chen wants to merge 1 commit into
Conversation
Replace Frameworks.getPlanner() with a custom validate+convert pipeline that uses BABEL conformance for parsing but disables isNonStrictGroupBy for validation. This fixes two ClickBench query failures: - q35: GROUP BY ordinal no longer wraps literals in ANY_VALUE - q40: CASE expressions in GROUP BY no longer trigger NPE in AggFinder Also unifies the SQL path with the PPL path by having CalciteNativeStrategy consume pre-parsed SqlNode from CalciteSqlQueryParser (reusing the shared UnifiedQueryParser interface) instead of duplicating parsing via PlannerImpl. Signed-off-by: Chen Dai <daichen@amazon.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Chen Dai <daichen@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace Frameworks.getPlanner() with a custom validate+convert pipeline that uses BABEL conformance for parsing but disables isNonStrictGroupBy for validation. This fixes two ClickBench query failures:
Also unifies the SQL path with the PPL path by having CalciteNativeStrategy consume pre-parsed SqlNode from CalciteSqlQueryParser (reusing the shared UnifiedQueryParser interface) instead of duplicating parsing via PlannerImpl.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.