Conversation
- Fix default theme not loading: always resolve aurora theme when no theme is specified, so prompt/margin settings match --theme aurora - Add unescape_xtrace to ShellAdapter (identity default for bash) - Implement ZshAdapter.unescape_xtrace to decode $'...' ANSI-C quoting produced by zsh xtrace (e.g. \C-[ → ESC) so directive values are stored as canonical bytes in .sc files - Wire adapter.unescape_xtrace into _postprocess, applied on dir events before directive post-processing - Regenerate assets with updated aurora theme prompt - Fix lint and typecheck (ruff I001/E702, mypy missing annotation, stale type: ignore)
dacrystal
force-pushed
the
feat/fix-default-theme-and-xtrace-unescape
branch
from
4b95884 to
75692dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Checklist
make allpasses locally (lint + typecheck + tests)DIRECTIVES.mdupdated (if directive added or changed)CHANGELOG.mdhas an entry (or I'm relying on the auto-changelog PR)Related issues