Skip to content

Conversation

@clemens-tolboom
Copy link

@clemens-tolboom clemens-tolboom commented Mar 15, 2018

This is a first shot at using the new Amara UI as described at https://github.com/pculture/unisubs/wiki/Embed-Code-Usage-Guide as where the Universal Subtitles is https://github.com/pculture/unisubs/wiki/Legacy-Embed-Code-Usage-Guide

The new Amara is currently disabled as there as some features to test.

Use Amara

wp option set wp_amara_use_legacy 0 

Use Universal subtitles

wp option set wp_amara_use_legacy 1

Open issues

  • Add UI for setting the new Amara On|Off
  • Add UI for default width and height (which makes users to only set the URL
  • Fix the other TODOs
  • Are all old providers supported especially *.flv?

@clemens-tolboom
Copy link
Author

On https://amara.org/en/videos/create/ they state

Acceptable Formats Include: Vimeo, Youtube, mp4, WebM, flv, ogg & mp3

which seems to me covers all old versions (blip.tv is no more)

@clemens-tolboom
Copy link
Author

@d79 AFAIK this PR is valid enough in itself ... not sure because it's long ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant