fix: Allow commenting out backend.cfg#988
Open
userwiths wants to merge 1 commit intocytopia:masterfrom
Open
Conversation
Regarding issue [cytopia#950](cytopia#950) Did not see any processing regarding if the option is commented out or not. Now we check if the first symbol is a semicolon (;) and in case it is, we return `default` rather than the commented out option.
Contributor
|
Commenting Out the Option ist useful, as it disables it. Please keep this possibility ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regarding issue #950
Did not see any processing regarding if the option is commented out or not. Now we check if the first symbol is a semicolon (;) and in case it is, we return
defaultrather than the commented out option.I did test this locally, and it seems the issue was purely visual.
When the semicolon (;) is present, we can see a message like this
[WARN] [second.loc] Backend rewrite config is invalid: Invalid backend string ';conf:phpfpm:tcp:php81:9000'. It must start with 'conf:'In the
Command & Controltab which stops the app from using the commented out backend and uses the default one.