-
Notifications
You must be signed in to change notification settings - Fork 33
Readme build instructions #410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
should be |
gonuke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A comment about port-forwarding and when it's necessary.
Also, does it make sense to describe how to serve it from inside a docker container and access it? Or do we assume/instruct people to bind mount everything and then launch the server from outside the docker container?
Fixed |
gonuke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks @dean-krueger
|
Oh - needs a rebase or similar |
…http.server 8000), which is the correct syntax of the command. Made change in both locations
2003c4b to
88e3dfd
Compare
|
I hit the "Update Branch --> Rebase" button here on GitHub and it looks like it did a bunch of stuff automatically for me. Not entirely sure if that was good or not, so I'm going to take another quick look. It might be worth the same from @gonuke before we go and hit any buttons (I'll probably not hit that button again). |
|
It looks like this should be fine? I guess worst case scenario it messes up the website and then I spent the weekend fixing it. |
|
Thanks @dean-krueger |
Previous versions of the README left users (me when I was trying to do this for the first time) high and dry after telling them to run
make docker-gh-preview. It was not at all clear that to actually view the changes made to the website it needed to be served and visited at localhost. This version of the README gives users (especially new ones) more detailed instructions on exactly what they need to do after they make changes to the website so that they can check their work.Closes #397