fix: CallbackVideoTrack._send_sync_frame → _capture_sync_frame#20
Merged
cyberdepa merged 1 commit intoMay 22, 2026
Conversation
CallbackVideoTrack.recv() calls self._send_sync_frame() but BaseVideoTrack only defines _capture_sync_frame(). This causes an AttributeError on every frame, preventing CallbackCameraStreamer from streaming any frames via WebRTC. CV2VideoTrack (camera_cv2.py) already uses the correct method name. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
|
Hi @paoloantinori Tagging @erlapso for a quick review on this one! |
Contributor
|
Hi @paoloantinori, thank you for the contribution 😄 Happy to say that this got merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CallbackVideoTrack.recv()callsself._send_sync_frame()butBaseVideoTrackonly defines_capture_sync_frame()AttributeErroron every frame, makingCallbackCameraStreamercompletely non-functionalWhat Changed
One-line fix in
cyberwave/sensor/camera_callback.pyline 115:CV2VideoTrackincamera_cv2.pyalready uses the correct method name.Testing
Tested with a
CallbackCameraStreamerthat relays frames from a UGV Beast robot to the Cyberwave cloud:capture_frame()via RESTTest plan
CallbackCameraStreamerstreams frames successfullycapture_frame()CV2CameraStreamer(already uses correct method)Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com