Skip to content

Conversation

@0xgouda
Copy link
Collaborator

@0xgouda 0xgouda commented Jan 16, 2026

  • Check if the needed time partition already exists before creating new partitions in postgres sink

TODO:

  • Add tests
  • Ensure a migration exists for the changes

Closes #1126

@coveralls
Copy link

coveralls commented Jan 16, 2026

Pull Request Test Coverage Report for Build 21290387143

Details

  • 17 of 23 (73.91%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 75.31%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/sinks/postgres.go 17 23 73.91%
Totals Coverage Status
Change from base Build 21245085454: 0.01%
Covered Lines: 4014
Relevant Lines: 5330

💛 - Coveralls

@pashagolub pashagolub added bug Something isn't working sinks Where and how to store monitored data labels Jan 21, 2026
@0xgouda 0xgouda marked this pull request as ready for review January 21, 2026 17:57
@0xgouda 0xgouda requested a review from pashagolub January 21, 2026 17:57
@0xgouda 0xgouda requested a review from pashagolub January 23, 2026 14:23
@0xgouda 0xgouda force-pushed the fix-partition-precreation branch from 6ad1129 to b01ac2a Compare January 23, 2026 14:30
Copy link
Collaborator

@pashagolub pashagolub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@pashagolub pashagolub force-pushed the fix-partition-precreation branch from b01ac2a to 601a8ae Compare January 23, 2026 14:54
@pashagolub pashagolub merged commit 3f69d22 into master Jan 23, 2026
8 checks passed
@pashagolub pashagolub deleted the fix-partition-precreation branch January 23, 2026 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working sinks Where and how to store monitored data

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pgwatch creates 4 new partitions each time it starts.

4 participants